search

ajoyce-sim / SummitReports

Web reports for Summit - Initially for underwriting
MIT License
0 stars 0 forks source link

UW - CF Report - Replace Special Chars in Tab Names #15

Open ajoyce-sim opened 4 years ago

ajoyce-sim commented 4 years ago

If the relationship has a special character in the name (i.e. "/","?", "#", etc.), It fails when you try to name a tab after sthe relationship.

Can we either

1) Replace all special characters with a space. 2) Replace the whole relationship name with a arbitrary number or string. 3) Other Suggestions?

Example uwRelationshipId = 296

ajoyce-sim commented 4 years ago

Can we do an error handler that if naming fails that the tab is just named to the relationship id?

OR maybe we should always name them by uwRelationshipId? There are no funky names and the assurance of uniqueness.

ajoyce-sim commented 4 years ago

Another example uwRelationshipId = 52

rvegajr commented 4 years ago

According to https://www.accountingweb.com/technology/excel/seven-characters-you-cant-use-in-worksheet-names: \/*[]:?

ajoyce-sim commented 4 years ago

I saw this.

I found an example where the users named two relationships the same thing (which will also cause an error. I think I’d just as soon go with uwRelatioshipid as the name of the tab. Thoughts?

Also, after doing some testing I found some tweaks that I need to make to the reports. To be clear, I should make the changes in the DeanSheet branch, push my changes and you will incorporate them in the next build, correct?

However, for the most part this looks great! The app is really coming together.

Thanks,

Aaron Joyce Managing Director – Information Technology Summit Investment Management LLC 1700 Lincoln Street, Suite 2150 Denver, CO 80203 720-221-3129 (direct) 412-225-5613 (cell) ajoyce@summit-investment.commailto:ajoyce@summit-investment.com www.summit-investment.comhttp://www.summit-investment.com/

[Summit Logo]

Except as expressly stated, emails, or any attachments, shall neither constitute acceptance of conducting transactions via electronic means nor create a binding contract in the absence of a fully signed written contract. The sender of this email expressly intends that the “signature block” and “from” portion of this email not be construed as an “electronic signature” or evidence of an intent to be bound as provided under any state law or act.

From: Ricardo Vega notifications@github.com Sent: Thursday, September 26, 2019 11:59 AM To: ajoyce-sim/SummitReports SummitReports@noreply.github.com Cc: Aaron Joyce ajoyce@summit-investment.com; Author author@noreply.github.com Subject: Re: [ajoyce-sim/SummitReports] UW - CF Report - Replace Special Chars in Tab Names (#15)

According to https://www.accountingweb.com/technology/excel/seven-characters-you-cant-use-in-worksheet-names: /*[]:?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ajoyce-sim/SummitReports/issues/15?email_source=notifications&email_token=ADAMOSUELYXZK33Y6QIXAM3QLTZ6TA5CNFSM4I2RU6T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7WOI3Q#issuecomment-535618670, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADAMOSRJBYPPRJDA76WAYCTQLTZ6TANCNFSM4I2RU6TQ.