[ ] All Tests are Passing
*There are 7 skipped tests that will need to be written (most using stubs), however all edge cases mentioned have been proven in Postman, to
[X] The code will run locally
Type of change
[x] New feature
[ ] Bug Fix
Implements/Fixes:
Had to create a new repo and move all previously written code over (previous repo was not created appropriately so was missing a significant amount of functionality)
Recipe:
created recipe service, poros, facade and serializer and requests
created spec files for associated testing
refactored after going down the wrong path with a Countries_Recipes serializer
created controller to handle
a user choosing a valid country
a random country being chosen for the user
a user choosing an invalid country/country that returns zero recipe results
created routes
Country:
created country service, poros, facade
created spec files for associated testing
Other:
added all required api keys to yml file
created schema and migrations
added multiple gems to gemfile
started ReadMe file
created project board and attached to this repo
description closes #
Check the correct boxes
[x] This broke nothing
[ ] This broke some stuff
[ ] This broke everything
Testing Changes
[ ] No Tests have been changed
[X] Some Tests have been changed
[ ] All of the Tests have been changed(Please describe what in the world happened)
Checklist:
*Refactored quite a few tests to accommodate code that had been refactored in recipes and countries
[ ] My code has no unused/commented out code
[x] I have reviewed my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have fully tested my code
*There are 7 tests that need to be written, made the decision to get through endpoints and come back to write tests later. Not ideal for TDD, however utilizing dream coding for getting services and endpoints setup.
X Wrote Tests X Implemented X Reviewed
Necessary checkmarks:
[ ] All Tests are Passing *There are 7 skipped tests that will need to be written (most using stubs), however all edge cases mentioned have been proven in Postman, to
[X] The code will run locally Type of change
[x] New feature [ ] Bug Fix Implements/Fixes: Had to create a new repo and move all previously written code over (previous repo was not created appropriately so was missing a significant amount of functionality) Recipe:
Country:
Other:
description closes # Check the correct boxes
[x] This broke nothing [ ] This broke some stuff [ ] This broke everything
Testing Changes [ ] No Tests have been changed [X] Some Tests have been changed [ ] All of the Tests have been changed(Please describe what in the world happened) Checklist:
*Refactored quite a few tests to accommodate code that had been refactored in recipes and countries
[ ] My code has no unused/commented out code [x] I have reviewed my code [x] I have commented my code, particularly in hard-to-understand areas [ ] I have fully tested my code
*There are 7 tests that need to be written, made the decision to get through endpoints and come back to write tests later. Not ideal for TDD, however utilizing dream coding for getting services and endpoints setup.