chore: MSRV 1.70 - Githubissues

fundon commented 1 month ago

ajrcarey commented 1 month ago

Why?

fundon commented 1 month ago

The bindgen minimum supported Rust version is 1.70.0.

ajrcarey commented 1 month ago

Thank you for taking the time over this, but I need to understand the rationale better before I approve.

bindgen is not a runtime dependency of this crate. It is only used at build-time, and then only if the "bindgen" crate feature is specifically selected, which is not the default.
bindgen is locked at 0.69.4 for this crate due to https://github.com/ajrcarey/pdfium-render/issues/156
cargo msrv shows that the MSRV for this crate with the image feature disabled is already 1.60.0
The README for this crate establishes a MSRV of 1.60.0

So with all that in mind, please walk me through the rationale for bumping the MSRV to 1.70.0. What would be the benefit?

ajrcarey / pdfium-render