Closed whikloj closed 6 years ago
Merging #7 into master will decrease coverage by
0.05%
. The diff coverage is52.94%
.
@@ Coverage Diff @@
## master #7 +/- ##
==========================================
- Coverage 61.35% 61.29% -0.06%
==========================================
Files 10 10
Lines 370 385 +15
Branches 40 44 +4
==========================================
+ Hits 227 236 +9
- Misses 127 132 +5
- Partials 16 17 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/main/java/edu/si/fcrepo/ObjectProcessor.java | 77.39% <52.94%> (-2.61%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update cb9bb79...3e14e0d. Read the comment docs.
I knew Codecov would throw a fit, @ajs6f once you have a chance to look at this and provide some feedback I can add some unit testing for the AkubraIDConverter
. Integration tests seem like they would be tougher based on what I can understand of your setup.
If I move this into the ObjectProcessor
it could be private
methods, but then I am unsure how to test it?
If I move this into the ObjectProcessor it could be private methods, but then I am unsure how to test it?
Oh, didn't see this! Yeah, that's more annoying. Well, at least package-private, okay?
Merging this mother...
Resolves #6
This needs review and probably some sort of test, but it resolves the issue for me when my DC datastreams are Managed instead of Inline Xml.