search

ajschumacher / rjstat

read and write JSON-stat with R
Other
31 stars 6 forks source link

CRAN failure... #21

Closed ajschumacher closed 2 years ago

ajschumacher commented 2 years ago

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_rjstat.html.

Please correct before 2022-03-09 to safely retain your package on CRAN.

The CRAN Team

Screen Shot 2022-03-06 at 1 48 44 PM
ajschumacher commented 2 years ago

It's only failing on the dev ones; I think I'll wait and see whether this remains a problem before I try to track down a dev version of R that it's failing for...

Status: Maybe a bug?

ajschumacher commented 2 years ago

(Maybe this is #20 showing up, and we can use the solution mentioned there...)

olangsrud commented 2 years ago

I am the maintainer of package PxWebApiData which depends on rjstat. I have received the mail saying that “Thus, package rjstat is now scheduled for archival on 2022-03-23, and archiving this will necessitate also archiving its CRAN strong reverse dependencies.”.

To avoid archiving of PxWebApiData I have prepared a version were code for the function fromJSONstat is copied from rjstat into PxWebApiData:

I have followed the recommendations in CRAN Repository Policy: Where code is copied (or derived) from the work of others (including from R itself), care must be taken that any copyright/license statements are preserved and authorship is not misrepresented. Preferably, an ‘Authors@R’ field would be used with ‘ctb’ roles for the authors of such code.

Therefore, I have now included the fromJSONstat authors, Aaron Schumacher and Håkon Malmedal, as authors of PxWebApiData with ‘ctb’ roles.

The original plan was to include fromJSONstat as a non-exported function. But in the last commit, the function is being exported, due to the needs of some users.

I hope this is an ok solution for you.

hmalmedal commented 2 years ago

@ajschumacher I made a fix and uploaded a new version to CRAN in your name. You will be sent an e-mail you must confirm.

ajschumacher commented 2 years ago

Thanks @hmalmedal! Done, but now I got another message:

""" Thanks, we see:

Found the following (possibly) invalid URLs: URL: https://coveralls.io/r/MansMeg/rjstat (moved to https://coveralls.io/github/MansMeg/rjstat) From: README.md Status: 301 Message: Moved Permanently URL: https://github.com/metacran/cranlogs.app (moved to https://github.com/r-hub/cranlogs.app) From: README.md Status: 301 Message: Moved Permanently

Please change http --> https, add trailing slashes, or follow moved content as appropriate.

Please fix and resubmit.

Best, Uwe Ligges """

hmalmedal commented 2 years ago

Reuploaded

ajschumacher commented 2 years ago

Success! Thanks @hmalmedal! You're a hero!

""" Dear maintainer,

thanks, package rjstat_0.4.2.tar.gz is on its way to CRAN.

Best regards, CRAN teams' auto-check service Package check result: OK

No changes to worse in reverse depends. """

@olangsrud hope that works for you! Sorry for the inconvenience!

ajschumacher commented 2 years ago

All resolved; closed #20, closing this too.

olangsrud commented 2 years ago

Nice with new CRAN version of rjstat. Then, I keep PxWebApiData as it is.