ajslater / codex

Codex is a web based comic archive browser and reader
GNU General Public License v3.0
210 stars 8 forks source link

Sort option for issue numbering #22

Closed hubbcaps closed 4 years ago

hubbcaps commented 4 years ago

Currently this request should ideally be fulfilled by Date Published, however something is occurring to separate issues within a series, see attached.

The addition of the number 1 next the comic name seems to be seperating them from the ones who don't have this additional numbering.

By sorting on just straight up issue numbering, I believe this can be avoided.

image

ajslater commented 4 years ago

Could you double check that the dates that seem out of order are indeed in the wrong position? It occurs to me that displaying the field sorted by in the browse tile would remove the mystery about whether this is a bug or not.

hubbcaps commented 4 years ago

Pretty sure, we can see here a pretty sharp jump in numbering

image

Then shortly below we can see it sort of reset when that "1" comes into the title there

image

The metadata difference between one of the titles without a "1" in the title

image

and one with the "1" in the title

image

ajslater commented 4 years ago

v0.5.9 will display more data in the browser to help us determine if the sort is really bad or not.

hubbcaps commented 4 years ago

So for comics that have a volume like seen here in there metadata, everything is good, but as we can see if they don't have meta data like volume, it ends up putting them after everything that does have the metadata.

In the case where using Folder view, might it be better to use the name of the file on disk rather than the name you're giving it via Codex?

image

Another interesting issue that can occur when sorting by something like Date Published is if the metadata isn't there it defaults to a name based sort it seems like, which is cool but maybe something better could be done to try to possibly guess the position based on issue number? Might require some weird parsing that might not be worth it, but possibly something to look into. Definitely more of a collection issue in not having that metadata available more than its an issue with Codex itself since the feature actually works if you're providing good data for it to use

image