search

ajstewart / racs-historical-transients

Module to perform transient searches between RACS and SUMSS/NVSS.
0 stars 3 forks source link

added SAMP coord broadcast to crossmatch detail #60

Closed marxide closed 5 years ago

marxide commented 5 years ago

Added a new panel to the crossmatch detail template to connect to a SAMP hub running on the user's machine and broadcast coordinates to all connected SAMP clients.

ajstewart commented 5 years ago

Looks good, I shall merge once I've pushed my own half-complete commit onto this branch.

ajstewart commented 5 years ago

@marxide you tested this on a local deployment right? I wonder if the website is hosted on ada will it still connect to the users machine on the network?

marxide commented 5 years ago

Yes, tested on a local deployment only. I think it should work deployed on ada; the SAMP stuff opens a connection to localhost by default and since this is all within Javascript running in the browser, that should point to the user's machine, not ada.

However, I did encounter problems with CORS during testing and needed to get around that with a browser plugin to temporarily allow CORS. In my experience, this workaround is only needed when testing without a properly configured webserver (e.g. the Django test server invoke with manage.py runserver). I suspect it should be fine on ada, but if not we can debug from there. I don't expect the SAMP stuff failing for work correctly to break anything else on the page.

ajstewart commented 5 years ago

Tested on ada - works well 👍 (at least on my setup!).

ajstewart commented 5 years ago

Is it normal behaviour that reset connection opens the connection request window in Aladin, but then selecting broadcast coordinates also opens the connection request? On the third click it will then go through and snap Aladain.