search

ajtowns / taproot-review

Taproot Review
61 stars 28 forks source link

Added optech taproot/schnorr library to PoC projects. #5

Closed jachiang closed 4 years ago

jachiang commented 4 years ago

Thanks for setting this repository up. I built a Schnorr/MuSig/Taproot library for Optech this summer at the Chaincode residency. The workshop repository which is linked contains a pretty complete Taproot library, with which most of the currently listed PoC projects could be built rather easily. For the purpose of evaluating the Schnorr/Taproot proposals, I suggest participants consider this PoC toolkit first, before investing time to reinvent the wheel?

moneyball commented 4 years ago

fixed this https://github.com/ajtowns/taproot-review/pull/8

On Wed, Oct 23, 2019 at 12:57 PM John Newbery notifications@github.com wrote:

@jnewbery commented on this pull request.

In PoC-Projects.md https://github.com/ajtowns/taproot-review/pull/5#discussion_r338246676:

@@ -9,3 +9,4 @@ These are some ideas for proof of concept projects to explore schnorr and/or tap

  • Taproot/Schnorr support for python-bitcoinlib (etc?)
  • ...

+Note: Optech has developed a Schnorr & Taproot library, which can be used to prototype many of the proof-of-concept projects suggested above. The library features a Schnorr and MuSig implementation as well as methods to construct Taproot outputs from various types of Tapscripts. The documentation is written in the form of interactive Jupyter notebooks, which provide thorough examples on how to use the library.

@jachiang https://github.com/jachiang - optech style guide is to lowercase schnorr and taproot (see https://github.com/bitcoinops/bitcoinops.github.io/blob/master/STYLE.md#common-nouns )

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ajtowns/taproot-review/pull/5?email_source=notifications&email_token=AACPUAYJSH7BVGTUQ2ZHYRDQQCUC7A5CNFSM4JEGNYHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCI7XNIY#pullrequestreview-306149027, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPUA7ZIHSSNTL7PWKF4ELQQCUC7ANCNFSM4JEGNYHA .

moneyball commented 4 years ago

the style guidelines say MuSig not musig

On Wed, Oct 23, 2019 at 10:54 PM James notifications@github.com wrote:

@jachiang commented on this pull request.

In PoC-Projects.md https://github.com/ajtowns/taproot-review/pull/5#discussion_r338392058:

@@ -9,3 +9,4 @@ These are some ideas for proof of concept projects to explore schnorr and/or tap

  • Taproot/Schnorr support for python-bitcoinlib (etc?)
  • ...

+Note: Optech has developed a Schnorr & Taproot library, which can be used to prototype many of the proof-of-concept projects suggested above. The library features a Schnorr and MuSig implementation as well as methods to construct Taproot outputs from various types of Tapscripts. The documentation is written in the form of interactive Jupyter notebooks, which provide thorough examples on how to use the library.

@jnewbery https://github.com/jnewbery - Just for my understanding, this extends to all following expressions: musig, taproot, taptree, tapscript as well?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ajtowns/taproot-review/pull/5?email_source=notifications&email_token=AACPUA5VOCE63VINB7E6GLLQQE2CTA5CNFSM4JEGNYHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJBEHHI#discussion_r338392058, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPUA3YKCKTGMJTC7V45NDQQE2CTANCNFSM4JEGNYHA .