ajv-validator / ajv

The fastest JSON schema Validator. Supports JSON Schema draft-04/06/07/2019-09/2020-12 and JSON Type Definition (RFC8927)
https://ajv.js.org
MIT License
13.72k stars 872 forks source link

Unexpected behaviour of unevaluatedProperties when used with dependentSchemas #2483

Open ahumellihuk opened 1 month ago

ahumellihuk commented 1 month ago

Code sandbox: https://codesandbox.io/s/ajv-playground-forked-nz924l?file=/src/index.js

What version of Ajv are you using? Does the issue happen if you use the latest version?

Latest 8.17.1

Ajv options object

Empty (no options)

JSON Schema

{
  "type": "object",
  "properties": {
    "name": {
      "type": "string"
    },
    "link": {
      "type": "boolean"
    }
  },
  "required": ["name"],
  "unevaluatedProperties": false,
  "dependentSchemas": {
    "link": {
      "if": {
        "properties": {
          "link": {
            "const": true
          }
        }
      },
      "then": {
        "properties": {
          "originalId": {
            "type": "string"
          }
        },
        "required": ["originalId"]
      }
    }
  }
}

Sample data

{
  "name": "test"
}

Your code

const Ajv2020 = require("ajv/dist/2020");
const ajv = new Ajv2020();

const schema = require("./schema.json");
const validate = ajv.compile(schema);

const valid = validate({
  name: "test"
});

Validation result, data AFTER validation, error messages

{
  "instancePath": "",
  "schemaPath": "#/unevaluatedProperties",
  "keyword": "unevaluatedProperties",
  "params": {
    "unevaluatedProperty": "name"
  },
  "message": "must NOT have unevaluated properties"
}

What results did you expect?

If I understand the JSON Schema specification around unevaluatedProperties and sub-schemas applied conditionally, the validation should pass with no errors given that name is defined in properties adjacent to unevaluatedProperties and it is present in the data instance.

Interestingly, the same example passes validation in https://www.jsonschemavalidator.net

Are you going to resolve the issue?

Looking for clarification/analysis from maintainers or those who are well-versed in latest JSON Schema specifications.

jasoniangreen commented 1 month ago

After looking at this issue for a while now I have to agree it does look like a bug. I have created this runkit example for convenience. It does seem that dependantSchema is interfering with name being considered an evaluated property because if I (a) remove dependentSchemas or (b) use another keyword like allOf to do any other processing this passes.

I will try and look into the dependentSchemas keyword to see if I can understand what's happening.