search

ajvb / kala

Modern Job Scheduler
MIT License
2.13k stars 188 forks source link

LockFreeJobCache, Consul support, Vendoring, Standardized error messages #157

Closed gwoo closed 7 years ago

gwoo commented 7 years ago

The LockFreeJobCache fixes a bug where inserting a new job would take several minutes or even timeout when a lot of jobs were in the cache. see #150 Consul Support which is very similar to #130 Moved to native go vendoring, but still using godep to manage for now. Added a few info messages and standardize on using jobName:jobId throughout.

ajvb commented 7 years ago

Would love to review this, but would be a lot easier if these changes were broken out into ~4 PR's.

gwoo commented 7 years ago

@ajvb Unfortunately there was no easy way to break this out into multiple PRs. I did a half way decent job of trying to organize it by commits.

LockFreeJobCache: https://github.com/ajvb/kala/pull/157/commits/069086f58302ce887b96f4bf348d86807ae7b5ff

There was another commit that just renamed it from FreeJobCache to LockFreeJobCache https://github.com/ajvb/kala/pull/157/commits/6919ac644a8df7ce132f2aaa674a696d75ac447b

Consul support: https://github.com/ajvb/kala/pull/157/commits/2e7053134e1e4924ac28c3e7df316a0726edf11e

Then, I added support for the address in https://github.com/ajvb/kala/pull/157/commits/13ab848cf4305a9b93bb64ad90e69f643e0822cb

Standardizing info messages: https://github.com/ajvb/kala/pull/157/commits/75e8f5c20eca94f0f69ca9522e120ebaf22ed47a

Fix failing tests: https://github.com/ajvb/kala/pull/157/commits/7ca69e6fc713d59d80e1de8a3249c9ff3fd164d7

go test -race was failing on the client tests

CircleCI v2: https://github.com/ajvb/kala/pull/157/commits/3aae973120c44de4813ac74738dbfabf8de1818b

Vendoring: https://github.com/ajvb/kala/pull/157/commits/0c986327f947d4bdd581b06a19e86a9e4a5d8b9e

Here is the switch to the vendor directory for latest versions of Go. While still using Godeps to manage it.