search

ajvb / kala

Modern Job Scheduler
MIT License
2.12k stars 187 forks source link

TLS for mysql #211

Closed up9cloud closed 4 years ago

tooolbox commented 4 years ago

Looks good, thanks!

Unfortunately looks like one of the tests still has a race condition. #205 is the ultimate solution but I don't think I will get to it soon. I will try to put in a temporary fix and then you'll need to adjust your pull request to include the patch so your checks pass, otherwise I can't merge.

tooolbox commented 4 years ago 
=== RUN   TestIntegrationTest
--- FAIL: TestIntegrationTest (0.01s)
    integration_test.go:53: Post http://127.0.0.1:46357/api/v1/job/: dial tcp 127.0.0.1:46357: connect: connection refused
FAIL

How bizarre, given that it just worked for several other commits.