search

ajvb / kala

Modern Job Scheduler
MIT License
2.12k stars 187 forks source link

Job Completion Notification #213

Closed tooolbox closed 4 years ago

tooolbox commented 4 years ago

Replaces https://github.com/ajvb/kala/pull/212

Fixes #205

I think there's something odd with the CircleCI settings, but I don't have access.

tooolbox commented 4 years ago

Fantastic...

tooolbox commented 4 years ago

@ajvb Hey man, it looks like the settings for CircleCI or GitHub workflows changed somehow because now there's this additional ci/circleci Expected — Waiting for status to be reported that I did not see in earlier PRs. For example, this one only has one check: https://github.com/ajvb/kala/pull/211

When I hit up Google, I see a lot of results recommending to "disable the check on the protected branch". Unfortunately I don't have access to the branch settings in this repo.

Could you assist? Thanks!

tooolbox commented 4 years ago

@ajvb So I figured out how to manually mark checks as complete to get around this particular issue, but it would still be great to fix this for the future.

Unfortunately I think this is my fault; when I clicked through to CircleCI I think it asked me if I wanted to upgrade to "Pipelines" and I hit "yes". The resulting problem is covered in the CircleCI docs: https://circleci.com/docs/2.0/workflows-waiting-status/

Basically seems like they changed the name of the checks and now this project is looking for the wrong one. So an admin (yourself) has to go in and fix that.

No particular rush but it would be good to resolve at some point.