search

ajvb / kala

Modern Job Scheduler
MIT License
2.11k stars 187 forks source link

Embed dashboard in binary #241

Closed demianbucik closed 1 year ago

demianbucik commented 3 years ago

PR to resolve https://github.com/ajvb/kala/issues/228.

To generate and serve embedded files we can use:

This adds approximately 0.6 MB to the binary size.

tooolbox commented 1 year ago

Thanks for this. Care to update the go.sum and I will merge?

demianbucik commented 1 year ago

Thanks for this. Care to update the go.sum and I will merge?

If Go version gets upgraded to 1.16 or above, I think this can now be done with //go:embed without external dependencies. If you agree, I can change the PR to use //go:embed instead.

Otherwise I'll update the go.sum to merge this as is.

demianbucik commented 1 year ago

Thanks for this. Care to update the go.sum and I will merge?

If Go version gets upgraded to 1.16 or above, I think this can now be done with //go:embed without external dependencies. If you agree, I can change the PR to use //go:embed instead.

Otherwise I'll update the go.sum to merge this as is.

@tooolbox Nevermind, I just saw on a different PR that you'd prefer to keep Go at 1.13. I merged master branch and updated go.sum. How does it look now?

tooolbox commented 1 year ago

LGTM