search

ajvincent / composite-collection

Composing Maps, WeakMaps, Sets and WeakSets into compiled classes
Mozilla Public License 2.0
1 stars 0 forks source link

Base template private maps on DefaultMap, use "as type" for required map checks. #108

Closed ajvincent closed 2 years ago

ajvincent commented 2 years ago

So many of the templates could clean their code up with DefaultMap.

ajvincent commented 2 years ago
ajvincent commented 2 years ago

  • Strong/OneMapOfStrongSets.in.mts in add() could use for RequiredMap, which isn't in the exports directory.

    • templates/OneToOne/Map.in.mts at delete() could use a .getRequired() from its base map.

This was incorrect, because .getRequired() is easily implemented in TypeScript via as foo checks.