search

ajvincent / es-membrane

An ECMAScript implementation of a Membrane, allowing users to dynamically hide, override, or extend objects in JavaScript with controlled effects on the original objects.
ISC License
109 stars 13 forks source link

GUI: Support extracting common source JavaScript files from archive #122

Closed ajvincent closed 6 years ago

ajvincent commented 6 years ago

If a developer can regularly provide a tarball as a build artifact, it would be much easier to maintain the ordering of scripts loaded. (There are JS libraries available for reading from tarballs.)

ajvincent commented 6 years ago

It doesn't have to be a tarball: I could pick some other common format like .zip if I feel like there is a mature enough (and modern enough) implementation for browsers.

ajvincent commented 6 years ago

JSZip is definitely modern enough: http://stuk.github.io/jszip/documentation/examples/read-local-file-api.html

ajvincent commented 6 years ago

https://github.com/ajvincent/es7-membrane/commit/071b684b40dcde23fb151ebc89864a67612e1f62

ajvincent commented 6 years ago

Fixed!

ajvincent commented 6 years ago

Whoops. Apparently checking a file doesn't guarantee it gets loaded...

ajvincent commented 6 years ago

Reopening again for the output panel...

ajvincent commented 6 years ago

Really fixed now.