ajwang / groovypptest

Automatically exported from code.google.com/p/groovypptest
0 stars 0 forks source link

groovypp*.jar and groovypp-all-*.jar are 3 KB different #337

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Now that groovypp-all-*.jar doesn't jarjar all core groovy stuff inside itself 
as before, I don't think it serves any purpose anymore.

Apart from being an extra artefact being generayed in build, it is also a 
source of confusion for people downloading from groovy++ maven repo, where they 
may expect groovypp-all-*.jar to be fatter and completely embeddable, like core 
groovy's.

If g++ now exists only as a plug-in to core groovy, only 1 jar is enough.

Original issue reported on code.google.com by roshanda...@gmail.com on 25 Jan 2011 at 2:46

GoogleCodeExporter commented 8 years ago
Unfortunately the situation is more complicated. When you use g++ together with 
groovy-all.jar you DO need to jarjar ASM classes inside exactly the same manner 
as it's done in groovy-core. Otherwise groovy-core compiler will not understand 
classes like MethodVisitor.

The idea of not including groovy core staff in to groovypp-all is exactly 
keeping g++ as plugin to groovy and not replacement, so ppl can deal with it as 
with library. For example, grails plugin simply adds it in to classpath instead 
of forcing you to use another groovy core.

Does it make sense now?

Original comment by alex.tka...@gmail.com on 25 Jan 2011 at 5:55

GoogleCodeExporter commented 8 years ago
It does. Thanks. 

Just decompiled some classes from both groovypp*.jar and groovypp-all*.jar and 
noticed that the other library classes are referred with jarjar naming in 
groovypp-all*.jar.

Original comment by roshanda...@gmail.com on 25 Jan 2011 at 6:05