Update to use new NASA POWER API

ajwdewit / pcse

Repository for the Python Crop Simulation Environment

Other

184 stars 125 forks source link

Update to use new NASA POWER API #48

Closed abegomez closed 2 years ago

abegomez commented 2 years ago

Updated to use new NASA Power API, however some parameter names are no longer being used: ALLSKY_TOA_SW_DWN (I used TOA_SW_DWN instead), PRECTOT (I used PRECTOTCORR instead).

The new API uses a different url: https://power.larc.nasa.gov/api/temporal/daily/point Also the payload uses a few different keys from the previous implementation: start, end, latitude, longitude, format

codename5281 commented 2 years ago

We had a look as well at the updated parameter names and ended up selecting the same ones, did not observe significant differences. Looking forward to this PR !

ajwdewit commented 2 years ago

Hi, thanks for making the required changes to the POWER weather data provider, it is just in time for the upcoming PCSE 5.5 update. Next time, please use the develop branch for pull requests normally I wouldn't allow pull requests on the master branch.

with best regards,

Allard