Query Regarding Nutrient Absorption in the Repository

ajwdewit / pcse

Repository for the Python Crop Simulation Environment

Other

191 stars 127 forks source link

Closed Yangclock closed 8 months ago

Yangclock commented 9 months ago

https://github.com/ajwdewit/pcse/blob/7daa80a055f8721493afe42bf1dbce4f7eb3e92b/pcse/soil/npk_soil_dynamics.py#L242 English isn't my first language, so I apologize if my expression is unclear. I've noticed an issue in the repository where the absorption values for phosphorus and potassium are set to the absorption value of nitrogen. This seems to result in negative soil nutrient values. Thank you for your time and consideration.

ajwdewit commented 8 months ago

Hi Yangclock,

Sorry for responding so late. The bug you found is indeed problematic. I fixed it in PCSE 5.5.6 which is on PyPI now.

Allard