ajwecker / TS1218

Tikkoun Sofrim crowd sourcing interface
0 stars 4 forks source link

there are no button texts for the translations of increase, decrease and font size #40

Closed dstoekl closed 5 years ago

dstoekl commented 5 years ago

in https://github.com/ajwecker/TS1218/tree/master/TS1218/src in no language, not even in English as far as I can see image

ajwecker commented 5 years ago

This working as designed since the text is hebrew. Maybe remove px I would prefer symbols for all the button half circle with arrow for reset (-) [+] {?} <~>

On Sat, Feb 9, 2019, 11:47 PM dstoekl <notifications@github.com wrote:

in https://github.com/ajwecker/TS1218/tree/master/TS1218/src in no language, not even in English as far as I can see [image: image] https://user-images.githubusercontent.com/39535215/52526678-93ffcf00-2cbc-11e9-8bf8-8fa5def72fc9.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ajwecker/TS1218/issues/40, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcwDRVbhhE-1B3kcE0uFQtb1Ttskc3tks5vL0H4gaJpZM4aywdu .

dstoekl commented 5 years ago

But we do have titles showing and they are in English even if the language is set to French

ajwecker commented 5 years ago

Titles indeed need msg texts Advantage of symbols is that you dont need separate pictures for tutorials

On Sat, Feb 9, 2019, 11:55 PM dstoekl <notifications@github.com wrote:

But we do have titles showing and they are in English even if the language is set to French

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ajwecker/TS1218/issues/40#issuecomment-462082789, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcwDYgsMGAssNgAQBn41rGD_fbaRFu0ks5vL0PPgaJpZM4aywdu .