ajwheeler / Korg.jl

fast 1D LTE stellar spectral synthesis
https://ajwheeler.github.io/Korg.jl/
BSD 3-Clause "New" or "Revised" License
39 stars 7 forks source link

missing molecules #168

Closed ajwheeler closed 6 months ago

ajwheeler commented 1 year ago

MARCS (and Turbospectrum, which uses the same list) include 527 molecules. Korg includes 271, of which 8 are not in MARCS. Of the ones which are not in Korg,

A lot of this data is from Irwin 1981 and Saubal and Tatum 1984, but there have been a couple dozen or so additions over the years according to the notes at the top of the file. I think we might be in the unfortunate situation that the only reasonably up-to-date and complete lists of K and D00 values are the SME and Turbospectrum/MARCS datafiles.

It's hard to tell which of these molecules exist in large quantities in stellar atmospheres without data to do calculations. As a test, it may be helpful to try out the Ks from the Turbospectrum datafile, but there's no way to know the effect of charged molecules without implementing support for them.

This issue is especially relevant in light of the fact that chemical equilibrium convergence is very effected by the list of molecules included. This also suggests that the molecular ions are the culprit. It's probably important to get them working.

ajwheeler commented 6 months ago

Closing this because it's out of date (Korg now supports charged molecules), and I no longer believe this is an accuracy bottleneck.