add Dissectig EXIT models

ajwills72 / catlearn

Formal Psychological Models of Categorization and Learning

GNU General Public License v3.0

23 stars 3 forks source link

add Dissectig EXIT models #4

Closed lenarddome closed 2 years ago

lenarddome commented 2 years ago

c++ implementation of two models from Paskewitz and Jones (2020)
- Model 4 is implemented as slpNNCAG - Neural Network with Competitive Attentional Gating
- Model 5 is implemented as slpNNRAS - Neural Network with Rapid Attentional Shifts
add testing units for both models
update rcpp compile attributes
minor tweaks to Readme and gitignore

ajwills72 commented 2 years ago

Looking good! I made minor tweaks to the documentation and to the formatting of comments in the CPP files. However, then discovered that the RData files needed for the unit tests are not in the repo (seem to have been added but have file size of zero). Fix that, and then let me know -- I'll then pick up by running the unit tests and, if they pass, merging and creating a new point version on master.

lenarddome commented 2 years ago

Awesome. Thanks for the comments and review!

I am unsure what is going on with the RData files - it is strange. They work on my end - both after cloning a new copy of the repository or downloading them directly from GitHub. I will do some digging and come back to it.

ajwills72 commented 2 years ago

Oh, weird. They are there now. They definitely weren't earlier today which is super odd. Hold fire, I'll have another go in a short while.