Similarity-Dissimilarity General-Context Model (Stewart and Morin 2007; O'Bryan, Worthy, Livesey and Davis, 2018)

[lenarddome]

• Add the implemention of similarity-dissimilarity general-context model (Stewart and Morin, 2007), that also includes settings to run the version of O'Bryan et al. (2018).
• Update Changelog

[ajwills72]

Overall this looks good - unit tests appropriate and they pass; I agree with your decision to classify as an 'slp' model. However, the Rd file is incomplete/buggy needs work, details below. If you could have another go at this then let me know, I'll take another look.

• x1, x2, x3 not defined (just above author field)
• 'ctrl' column referred to but does not seem to actually exist (just above x1, x2 entry)
• In example, 'names' is defined but does not seem to be used?
• \value mentions that a matrix 'v' is returned, but 2nd para of details only mentions matrix of response probabilities.
• It's not so clear to me what 'v' actually is?
• Two parameters (b, base) are both described as 'baseline level of similarity'; this could use some further clarification.
• 'beta' is a bias vector, but allowable/sensible values should also be included.

[lenarddome]

I made the improvements to the documentation. The branch is ready for another round of review 🙂