search

ajylla / SPOT

Solar Particle Onset Tool
1 stars 4 forks source link

channel='flux' option of onset_analysis() #7

Open jgieseler opened 2 years ago

jgieseler commented 2 years ago

Is the channel='flux' option in onset_analysis() really necessary (cf. functions.py#L497)? I think it originates from the output Dataframe of calc_av_en_flux_EPT() and calc_av_en_flux_HET() having this column name ('flux'), but as this Dataframe has (and only should have) only one column, it seems to be redundant (and confuses with other datasets that don't have the same column name 😉).

jgieseler commented 2 years ago

Okay, so it seems to be not really necessary, but also not bugging too much. Should be removed at a later time, preferably when calc_av_en_flux_EPT() and calc_av_en_flux_HET() are united in one function, which should be provided from a central package (maybe solo-epd-loader?).