ak-gupta / nbaspa

Survival-analysis powered NBA player impact ratings
https://nbaspa.readthedocs.io
MIT License
2 stars 0 forks source link

Continuing to improve code quality and QA #11

Closed ak-gupta closed 3 years ago

ak-gupta commented 3 years ago

In this PR, I've

codecov-io commented 3 years ago

Codecov Report

Merging #11 (e7f60f7) into develop (d89a4ef) will increase coverage by 0.01%. The diff coverage is 62.92%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #11      +/-   ##
===========================================
+ Coverage    52.03%   52.05%   +0.01%     
===========================================
  Files           48       48              
  Lines         1820     1827       +7     
===========================================
+ Hits           947      951       +4     
- Misses         873      876       +3     
Impacted Files Coverage Δ
nbaspa/model/pipeline.py 0.00% <0.00%> (ø)
nbaspa/model/tasks/data.py 0.00% <0.00%> (ø)
nbaspa/model/tasks/io.py 0.00% <0.00%> (ø)
nbaspa/model/tasks/lifelines.py 0.00% <0.00%> (ø)
nbaspa/model/tasks/metrics.py 0.00% <0.00%> (ø)
nbaspa/model/tasks/predict.py 0.00% <0.00%> (ø)
nbaspa/model/tasks/tuning.py 0.00% <0.00%> (ø)
nbaspa/model/tasks/visualization.py 0.00% <0.00%> (ø)
nbaspa/model/tasks/xgboost.py 0.00% <0.00%> (ø)
nbaspa/player_rating/pipeline.py 0.00% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d89a4ef...e7f60f7. Read the comment docs.