search

ak-gupta / nbaspa

Survival-analysis powered NBA player impact ratings
https://nbaspa.readthedocs.io
MIT License
2 stars 0 forks source link

Additional QA tools and better test coverage #13

Closed ak-gupta closed 3 years ago

ak-gupta commented 3 years ago

In this PR, I've added

codecov-io commented 3 years ago

Codecov Report

Merging #13 (63a071c) into master (d89a4ef) will increase coverage by 27.77%. The diff coverage is 89.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #13       +/-   ##
===========================================
+ Coverage   52.03%   79.81%   +27.77%     
===========================================
  Files          48       48               
  Lines        1820     1798       -22     
===========================================
+ Hits          947     1435      +488     
+ Misses        873      363      -510
Impacted Files Coverage Δ
nbaspa/data/scripts/clean.py 77.96% <ø> (ø)
nbaspa/player_rating/pipeline.py 0.00% <0.00%> (ø)
nbaspa/player_rating/tasks/impact.py 0.00% <0.00%> (ø)
nbaspa/player_rating/tasks/io.py 0.00% <0.00%> (ø)
nbaspa/data/endpoints/base.py 97.36% <83.33%> (-1.30%) :arrow_down:
nbaspa/data/endpoints/scoreboard.py 95.00% <87.50%> (-5.00%) :arrow_down:
nbaspa/data/endpoints/parameters.py 78.22% <100.00%> (+0.44%) :arrow_up:
nbaspa/data/pipeline.py 100.00% <100.00%> (ø)
nbaspa/data/tasks/gamelog.py 100.00% <100.00%> (ø)
nbaspa/data/tasks/io.py 95.04% <100.00%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d89a4ef...63a071c. Read the comment docs.