search

ak1394 / react-native-tts

React Native Text-To-Speech library for Android and iOS
618 stars 156 forks source link

Add Windows support #161

Closed tritao closed 3 years ago

tritao commented 3 years ago

This pull request adds support for running react-native-tts with react-native-windows.

For context, I've also opened a PR which updates the example to the latest react-native 0.63 and adds an Windows example: https://github.com/themostaza/react-native-tts-example/pull/2

tritao commented 3 years ago

Hi @stmoy, thanks for the review feedback, I've further refined the code on the PR, it's now using a MediaPlayer directly instead of going through either a MediaElement or MediaPlayerElement. This simplifies setup and usage of the module, it no longer requires the addition of the element to the XAML tree.

ak1394 commented 3 years ago

Thansk for the contribution @tritao ! It looks good, and I intend to merge and release a new version with it soon. Would you be able to test master on windows before the release? I can't test windows buld myself.

tritao commented 3 years ago

Thansk for the contribution @tritao ! It looks good, and I intend to merge and release a new version with it soon. Would you be able to test master on windows before the release? I can't test windows buld myself.

Sure, let me know when its ready and I'll test it.

tritao commented 3 years ago

@ak1394 By the way, I'm also working on CI and automated testing for this module, would you (and @themostaza) be open to merging the example in https://github.com/themostaza/react-native-tts-example in this repo for easier setup?

ak1394 commented 3 years ago

Yes, it would be great to have some CI and tests

ak1394 commented 3 years ago

Hi @tritao I've merged PR, could you test it and let me know if it looks good?

tritao commented 3 years ago

@ak1394 Thanks for the merge, will do.