ak1394 / react-native-tts

React Native Text-To-Speech library for Android and iOS
603 stars 154 forks source link

Example and Windows CI #164

Closed tritao closed 3 years ago

ak1394 commented 3 years ago

Hi @tritao ! I've merged the latest changes, but I'm seeing the failure during the build:

tritao commented 3 years ago

I'll check it out on Monday

tritao commented 3 years ago

Hey @ak1394, sorry I have not looked into the CI issue yet, will be fixed ASAP.

ak1394 commented 3 years ago

No worries @tritao thanks for looking into it!

ak1394 commented 3 years ago

BTW is https://github.com/ak1394/react-native-tts/pull/169 anyhow related to it?

tritao commented 3 years ago

I think so, but there are other issues, CI is too slow and fails with the time delays specified in the tests.

@jaimecbernardo was looking into it, I will coordinate with him and either of us should be sending a PR to get it fixed.

jaimecbernardo commented 3 years ago

Turns out GitHub actions environment is not able to use TextToSpeech correctly. I've tested using these in the environment through the PowerShell and the object returned is empty.

Add-Type -AssemblyName System.speech
$speak = New-Object System.Speech.Synthesis.SpeechSynthesizer
$speak.GetInstalledVoices().VoiceInfo

$speak.GetInstalledVoices() fails because the $speak object is empty.
Given that this API seems to be unusable for the GitHub actions, I've added some changes to https://github.com/ak1394/react-native-tts/pull/169 so that CI runs a simpler version of the test that just builds and verifies that the Application runs successfully.

ak1394 commented 3 years ago

@jaimecbernardo sounds good, thanks!