search

ak1394 / react-native-tts

React Native Text-To-Speech library for Android and iOS
626 stars 159 forks source link

fix(windows): bump windows WindowsTargetPlatform #244

Open TatianaKapos opened 1 year ago

TatianaKapos commented 1 year ago

In RNW .72, we bump WinUI from 2.7 to 2.8 which targets a higher TargetPlatformMinVersion. This PR bumps the WindowsTargetPlatformMinVersion to the correct version for RNW .72

TatianaKapos commented 1 year ago

@ak1394 would you mind looking at this PR when you have the chance? :) It blocks RNW apps from using .72

ak1394 commented 1 year ago

Hi @TatianaKapos ! Sure, I'll merge it. But using a chance to talk to someone at MS, I wanted to see if anyone on your side would be interested in updating the example app? It has been contributed by MS folks and I think it needs an update. Otherwise I'm going to remove it.

TatianaKapos commented 1 year ago

@ak1394 just put a PR out to bump the RNW version of the example app to .72! I only had the time/resources to bump the windows side of the app, you'll probably want to double check the IOS/Android version of the app if those are important to you.