search

ak1394 / react-native-tts

React Native Text-To-Speech library for Android and iOS
620 stars 156 forks source link

Update Android build.gradle to latest versions #69

Open ripern opened 6 years ago

ripern commented 6 years ago

Would it be okay to update compileSdkVersion, targetSdkVersion, support:support, support:appcompat versions to 27 in build.gradle as shown below? If yes, I can make a pull request.

`apply plugin: 'com.android.library'

android { compileSdkVersion 27

defaultConfig {
    minSdkVersion 16
    targetSdkVersion 27
    versionCode 1
    versionName "1.0"
}

}

dependencies { compile fileTree(include: ['*.jar'], dir: 'libs') compile 'com.android.support:support-v4:27.1.0' compile 'com.android.support:appcompat-v7:27.1.0' compile 'com.facebook.react:react-native:+' }`

ak1394 commented 6 years ago

I'm not sure. The react-native itself seems to be at 22? https://github.com/facebook/react-native/issues/17287 I'm bit out of touch with react-native development, especially an android, so I would like to see some more opinions on this