Costume passives bug

[JordanLeich]

Author: Cohollow

Date: 20.12.2021

Bug: Most of the costume passives that add to a characters power damage don't work. (Eg. Storm, Human Torch) Thing's powers passive works.

[ak2yny]

There may be other, non-power-boost passives, which may be wrong. Cohollow had a list (which may be lost), and other MUA fans reported generally buggy passives as well (no specifics known yet). Check the closed issues for fixed bugs.

[JordanLeich]

I just tested Storm, Human Torch, and Thing's costume power damage passives and they all did not work as intended. They all output the same amount of damage with powers no matter how highly or low upgraded the power damage passive is. I will look into fixing this if possible. Colossus needs this fix as well.

[JordanLeich]

This for example is the code responsible for Storms passive to add dmg to all powers but it doesn't work as intended.

talent {
   descname = Weather Mastery ;
   description = Increases the $DMG of all powers. ;
   icon = 7 ;
   icon_texture = textures/ui/storm_icons1.png ;
   name = storm_outfit22 ;
   skin = 1 ;
   type = passive ;
      talentvalues {
         talentvalue {
         level = 1 ;
         name = storm_outfit22_pct ;
         value = 1.03 ;
         }

     talentvalue {
     level = 9 ;
     name = storm_outfit22_pct ;
     value = 1.15 ;
     }

  }

  level {
  count = 9 ;
  description = %storm_outfit22_pct:s Power $DMG ;
     powerup {
     life = -1 ;
        affecter {
        attribute = atk_damage ;
        level = %storm_outfit22_pct ;
        scope_powers = true ;
        }

     }

[techurious]

Are you sure it doesn't work? Try changing the value to 2 to see the obvious damage change that should doubly increase power damage. Low damage bonus (3 - 15%) is barely noticeable. If it doesn't work, then it needs "affect_type = scale" to function.

EDIT: just checked, and it does need affect_type = scale. Although it doesn't work for Chain Lightining damage for some reason. As if it's not a power (might have to do with indirect damage via harming powerup).

[JordanLeich]

Are you sure it doesn't work? Try changing the value to 2 to see the obvious damage change that should doubly increase power damage. Low damage bonus (3 - 15%) is barely noticeable. If it doesn't work, then it needs "affect_type = scale" to function.

EDIT: just checked, and it does need affect_type = scale. Although it doesn't work for Chain Lightining damage for some reason. As if it's not a power (might have to do with indirect damage via harming powerup).

Yeah I was having major issues with adding affect_type = scale to storms talent file, it wouldn't compile, im not sure if this also applies to human torch or colossus because I haven't looked at them yet. I forgot to mention that I did testing with mr fantastic and the passive increase power damage does work and he does have the affect_type = scale code.

[techurious]

@JordanLeich what are you using for compiling? I added that with no problem using the QuickBatch. Don't forget about the syntax.

[JordanLeich]

@JordanLeich what are you using for compiling? I added that with no problem using the QuickBatch. Don't forget about the syntax.

I was using the good old XMLBCUI program which is more than likely the issue, I was switch over to QuickBatch when I get the chance to.

[techurious]

P.S. are we still using the repository for updates? I could fix Storm's talent file myself in that case.

[JordanLeich]

P.S. are we still using the repository for updates? I could fix Storm's talent file myself in that case.

I believe me and @ak2yny are so yeah you can go ahead and fix it if you'd like. I'm not home for awhile so I can't fix anything right now but I know that human torch and colossus likely suffer from the same problem as storm. I know that mr fantastics increase power damage passive already works.

[JordanLeich]

So it turns out that Storm from what I could find was the only character missing the affect_type = scale in the talent file so I just fixed that. However, I will leave this issue open on GitHub just in the case that we find more costume passive bugs or cohollow shares his list of bugs. I can also confirm that Human Torch, Colossus, and the Thing all work with the increased dmg passive so they don't need any fixing, looks like Storm only had this issue.

[ak2yny]

While doing Critical Strike for #50 , I found that some used atk_critical and others critical for attribute. I tested them and they both seem to work identically for melee attacks. So that can be ignored.