Fightstyles should be removed

[JordanLeich]

Author: ak2yny (based on reports by UltraMegaMagnus and others)

TODO: Fightstyles should really be removed. May cause issues for a few boosters that they're not able to block anymore (removed block talents).

• [ ] Mods and boosters of active modders: Instead of fixing their mods, inform them of the tasks that will fix their mods.
  • [ ] custom fightstyles
  • [x] mix animations
  • [x] update powerstyle to include missing fightstyle code (not all modders were informed to do that, but I'm assuming that they do that anyway)
  • [x] remove from actors
  • [x] remove from data/fightstyles
  • [x] remove from talent file
  • [x] remove from herostat
  • [ ] remove from packages (not all are included in packages)
  • [ ] default fightstyle
  • [ ] mix animations
  • [ ] remove from packages (very few are included in packages)
• [x] Mix animations of all characters using custom fightstyles. (Ceamonks890)
• [ ] Mix code of all custom fightstyles to the powerstyle, if it is different from fightstyle_default, and if it's not already a fightmove existing in the powerstyle
• [ ] Update powerstyle code to make sure that the newly added fightstyle_default code doesn't change the mod's behaviour.
• [ ] For all remaining mods and boosters, mix animations of 07_captamerica_4_combat.igb, if the mod uses a fightmove and its animation is not already included. Check code of following files for animations:
  • [ ] powerstyle
  • [ ] data/fightstyles/fightstyle_default.xmlb (7 animations to check only)
• [ ] The OCP 1 added fightstyles for each character (e.g. fightstyle_thor) in ...
  • [ ] ... actors
  • [ ] ... data/fightstyles
  • [ ] ... packages/generated/fightstyles
  • To do: remove after mixing.
  • The problem: extra fightstyles add to the workload which has a limit. Resulting bugs: powers not working, effect issues, freeze while loading (worst), crashes.
• [ ] The OCP 1 also added a new actors/fightstyle_default.igb, which is a copy of actors/07_captamerica_4_combat.igb.
  • To do: remove after mixing.
  • The problem: fightstyle_default has higher priority than common_combat, so the OCP1 version replaces some animations, like blocking, but different and without ponytail animations. Most old mods require the OCP1, so a few of these mods use animations from the OCP1 actors/fightstyle_default.igb. So, that animation set can't just be removed, first, all mods have to be checked and fixed if necessary.

[ak2yny]

We agreed to combine this with the animation mixing fix by Ceamonks890, since the nature of it is similar and both must be installed after installing any old mod. I started to do this a long time ago but other projects came up, a new PC, a broken HDD, etc. Now, I finally restored the files that I had been working with (in hopes that none, or only few are corrupt), so if anyone wants to continue where I left off, here are the files: Update for Animation Mix Fix by Ceamonks, incl. changelog Check the files, as it is very important that none of them are corrupt. Animation files of all mods, and a list of ps, fightstyles etc. which have animations that need to be checked The second link has been scanned for animations which are not in the character animation files. Some of them I scanned twice, once before, and once after installing the Animation Mix Fix. Since I decided to build the update on the Animation Mix Fix, we can ignore the former lists and focus on the lists for fixed animations, which have the wma suffix (with mixed animations). Some problematic/missing animations may be in fightstyles, incl. any fightstyle that comes with the mod, one that comes with the OCP (eg. fightstyle_blackpanther), and/or the fightstyle_default from the OCP.

I am still unsure as to how to handle the animations from the OCP fightstyle_default. I think that any power animation should be mixed into the mods character animation files, while melee and non attack (eg. blocking) animations should be taken from common_combat (some new will be added in #4 ) which will have ponytail animation for the ladies. This may change some melee moves, so it may be a good idea to double-check that, especially for the gentlemen who don't have rigged hair.

[ak2yny]

The update files could also be added to the Compatibility pack for boosters.

Both packs (Animation fix by Caeamonks890 and the Compatibility pack) are mentioned in the Readme > Troubleshooting 1b

[ak2yny]

Added the Animation fix files to the temporary folder. If anyone wants to collaborate with me on this, he can use the mod archive and the included lists to check each character for potential problems and update them here if necessary. New mods don't have to be checked. All active modders have been notified about the issue and the future OCP change.