search

ak86 / Milk-Mod-Economy

http://www.loverslab.com/files/file/1382-milk-mod-economy/
2 stars 0 forks source link

PR for refactoring "BreastBase" / "BreastBaseMod" & "WeightBase" #4

Closed ghost closed 8 years ago

ghost commented 8 years ago

Reorganized PullRequest (modified files have been compiled and tested in Skyrim)

Regarding the comment: "i think i should be return StorageUtil.GetFloatValue(akActor, "MME.MilkMaid.BreastBaseMod", missing = NetImmerse.GetNodeScale(akActor, "NPC L Breast", false)) otherwise i can probably cause an error if "MME.MilkMaid.BreastBaseMod" was not set for some reason"

I don't think so because BreastBaseMod is initialized explicitly to 0 and that is also StorageUtil's default if no 'missing =' is provided. Maybe you thought of "MME.MilkMaid.BreastBase" instead, but there's already a safeguard if the value does not exist for whatever reason (line 69). This safeguard should never trigger, because initializeActor() is responsible for initializing the value. If it triggers then I guess either initializeActor() has not been called or something deleted the value.

ak86 commented 8 years ago

well if its StorageUtil's default, then okay i guess it will trigger often, cuz users dont read changelogs, and tend to break everything