search

akaJes / marlin-config

Marlin firmware instant configurator
GNU General Public License v3.0
389 stars 85 forks source link

bugfix-2.0.x no longer loading as of commit 274934a #104

Open Pyro-Fox opened 5 years ago

Pyro-Fox commented 5 years ago

I tried to grab the latest Marlin bugfix-2.0.x branch using Marlin-Conf and the UI no longer loads up the config file. I kept stepping back through commits until it worked and can see that it broke after 274934a.

I really don't understand what might be happening other than, Marlin-Conf works on 179d6c4 from 8/14/2019... Working

...but totally breaks on the next commit 274934a from 8/16/2019. Not working

akaJes commented 5 years ago

Hi, the App catch a fail and stops when it was parsed this wrong text

//#defined LULZBOT_TOUCH_UI

this is a two sided issue

  1. wrong comment in the source Configuration.h
  2. prevent this situation and fix the regexp in the line https://github.com/akaJes/marlin-config/blob/master/app/mc.js#L37
akaJes commented 5 years ago

it was marked as typo and fixed in the source here https://github.com/MarlinFirmware/Marlin/blame/bugfix-2.0.x/Marlin/Configuration.h#L2041

yet-another-average-joe commented 5 years ago

@akaJes : happy to read you again !