search

akabekobeko / npm-gatsby-remark-copy-relative-linked-files

Copies local files relative linked to/from markdown to your public folder with preserve directory structure.
MIT License
6 stars 3 forks source link

Windows support? #22

Closed karlhorky closed 3 years ago

karlhorky commented 3 years ago

Hi @akabekobeko 👋 hope you are well!

Just forwarding an issue that @Josehower has been experiencing on his Windows machine:

It appears that this plugin doesn't work with Windows (maybe an issue with the slashes in the paths?)

Screen Shot 2021-07-15 at 11 21 47
akabekobeko commented 3 years ago

@karlhorky We have not confirmed the operation on Windows. But I want to support it, so I will investigate.

It may take some time.

akabekobeko commented 3 years ago

Tested on Windows with GitHub Actions failed. Expected to be due to path character processing.

akabekobeko commented 3 years ago

@karlhorky Fixed to pass automated tests on Windows. It was released as v1.4.0, so please check it.

karlhorky commented 3 years ago

Nice, thanks!

@Josehower can you please take a look?

akabekobeko commented 3 years ago

I don't have a Windows environment at hand, so I've confirmed that the unit test succeeds in the VM environment of GitHub Actions.

Please let me know if the problem reappears. Add cases that meet the conditions to the unit test.

Josehower commented 3 years ago

Hey! thank you so much

i can confirm now the pluggin is working as expected.

really appreciate your time and effort solving this issue.

Have a nice one!!!

image

karlhorky commented 3 years ago

Great, thanks for checking José! Closing :)