search

akabekobeko / npm-icon-gen

Icon file generator for Windows, macOS, Web
MIT License
157 stars 29 forks source link

Mac OS X finder uses also is32 and il32 icns. #68

Closed abramobagnara closed 7 years ago

abramobagnara commented 7 years ago

Without this patch the list view in finder does not show the right icon for an electron-packager app.

akabekobeko commented 7 years ago

@abramobagnara

Sorry for the late reply.

is32 andil32 are in a special format with a set of colors and masks (s8mk andl8mk).

Therefore it is not enough to just add the size. The difficulty of implementation was high and I gave up in the past. However, after receiving your pull request, I decided to challenge again on issue #71.

It seems that it will take time, but it will correspond with #71.

abramobagnara commented 7 years ago

From what I've verified with my trivial changes, is32 and il32 are enough (also without s8mk and l8mk) to have the correct icon for list view in OS X finder.

Is there a reason to make things more complex than needed? Am I missing something?

akabekobeko commented 7 years ago

@abramobagnara

is32 and il32 are not 32 bit PNG. If simply add 16x16 and 32x32 icons, only need to support icp4 and icp5, but the #54 problem occurs.

Therefore it is necessary to support is32 and il32 correctly.

akabekobeko commented 7 years ago

@abramobagnara

Supporting is32 andil32 with icon-gen v1.2.0.

I also confirmed that the icon created by icon-gen was set with electron-packager and the list display of Finder was performed normally (on macOS High Sierra).

This pull request will close.

If the problem reappears please report again.