akabiru / todos-api

🍻 🍾 @scotch-io tutorial "Build a RESTful JSON API with Rails 5" codebase.
https://scotch.io/tutorials/build-a-restful-json-api-with-rails-5-part-one
MIT License
188 stars 101 forks source link

Adjustment for rails 5.2.0 #24

Closed ksdputra closed 5 years ago

ksdputra commented 6 years ago

As we discuss before, Austin. I add new HMAC_SECRET that suitable for rails 5.2.0. I did not delete the old HMAC_SECRET, as the change only for rails 5.2.0. I gave descriptions when to use a HMAC_SECRET.

Sorry for late PR. Sorry for bad english.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-14.2%) to 84.828% when pulling 839846606fec3348d7f2166b9eac85ba2e4e110f on thekingisme:master into d8c70937e621989b22dfd74dd520bce8f3c1799b on akabiru:master.

akabiru commented 6 years ago

Cheers @thekingisme 🙂I'll set some to review this.

akabiru commented 6 years ago

We'll need to fix the tests though. 🙂

akabiru commented 5 years ago

Hey @thekingisme , I wanted to personally thank you for your contribution. I'm going to archive this repo temporarily as I don't have the bandwidth to look after it. The tutorial will still be available and the code for reference.