search

akaffenberger / firebase-ios-sdk-xcframeworks

A small mirror for https://github.com/firebase/firebase-ios-sdk, to add support for binary (xcframework) distribution with swift package manager.
MIT License
134 stars 32 forks source link

Set AppAuth dependency instead of referencing binaryTarget #32

Closed adriencog closed 2 years ago

adriencog commented 2 years ago

When using your (very helpful) package, I encountered a conflict using AppAuth in SPM. Because this package is using binary target, SPM is not able to resolve AppAuth dependency if you use it too.

Using AppAuth package solves the issue, but please note that I don't use GoogleSignIn. GoogleSignIn package refers to the same AppAuth version, so it shouldn't cause any issue. https://github.com/google/GoogleSignIn-iOS/blob/main/Package.swift

akaffenberger commented 2 years ago

Thank you for your PR @AdrienCog! Unfortunately due to how SPM packages are embedded this would actually cause a compile time error for those using the GoogleSignIn dependency.

There was a similar SPM collision issue encountered with SwiftProtobuf (see #29).

Since you are not using GoogleSignIn, the solution I proposed in that thread (renaming the binary target) should solve your collision issue as well. I should have a PR available for that fix either today or tomorrow. (Just be aware that if you do plan on using GoogleSignIn in the future, you will likely run into duplicate architecture compile time issues).

akaffenberger commented 2 years ago

@AdrienCog Your issue should be resolved now, please try version 9.1.0, let me know if you run into any issues.