Cannot build app with `firebase-ios-sdk` v10.24.0

akaffenberger / firebase-ios-sdk-xcframeworks

A small mirror for https://github.com/firebase/firebase-ios-sdk, to add support for binary (xcframework) distribution with swift package manager.

MIT License

134 stars 32 forks source link

Open ski-u opened 2 months ago

ski-u commented 2 months ago

Hi, thank you for working for this project! 👋 I submit an issue because I have a problem with the new version (10.24.0)

I can't build our app with akaffenberger/firebase-ios-sdk-xcframeworks 10.24.0
- Errors said that the signatures can't be verified
If I add firebase/firebase-ios-sdk directly as a SPM package, I can build our app 🙆

I made a repository that contains minimum projects to reproduce this issue
- https://github.com/ski-u/firebase-ios-sdk-signature
We may have the same error when building iOS Example project in this repo

❯ swift --version
swift-driver version: 1.90.11.1 Apple Swift version 5.10 (swiftlang-5.10.0.13 clang-1500.3.9.4)
Target: arm64-apple-macosx14.0

❯ xcodebuild -version
Xcode 15.3
Build version 15E204a

mathaeus commented 2 months ago

+1 here

formaad commented 2 months ago

tareksabry1337 commented 2 months ago

lkuczborski commented 2 months ago

+1 @akaffenberger Will you be able to take a look? :)

MartinPrusa commented 2 months ago

This issue is reported on Firebase Github https://github.com/firebase/firebase-ios-sdk/issues/12800, fix must be done on their side

am-play commented 2 months ago

@akaffenberger It looks like google may have fixed this in 10.25.0: https://github.com/firebase/firebase-ios-sdk/issues/12800#issuecomment-2059516188 Could you update to 10.25.0? Thanks!

alexfringes commented 2 months ago

@am-play Just FYI, 10.25.0 isn't the current version on the official Firebase iOS repo yet.

akaffenberger commented 2 months ago

Hey all, sorry for the delay, updating it now.

lkuczborski commented 1 month ago

Hmm... having same issues in 10.25.0 too :(

mathaeus commented 1 month ago

Also still experiencing this issue with 10.25.0.

lkuczborski commented 1 month ago

So it appears that these binaries are not signed properly. Signatures are required for binary dependencies as described here: https://developer.apple.com/support/third-party-SDK-requirements/

ski-u commented 1 month ago

@akaffenberger We're still having the same issue with 10.25.0 😢 Will you be able to take a look?

We would like to update firebase-ios-sdk to the latest version since it contains some updates related to Apple Privacy Manifest!

daniapopov commented 1 week ago

I have put up a PR that I think addresses the issue