search

akahuku / wasavi

wasavi is an extension for Chrome, Firefox, and Opera. wasavi changes a textarea element to virtual vi editor which supports almost all the vi/ex commands.
http://appsweets.net/wasavi/
Other
1.51k stars 66 forks source link

Doesn't work on firefox 32-35 (agent.js:extension.urlinfo is not defined) #39

Open fmoralesc opened 10 years ago

fmoralesc commented 10 years ago

Probably a change in the plugin API.

I am using vimfx too, and I thought it might have some conflict with it, but disabling it didn't fix the issue.

ahal commented 10 years ago

It fails to load, here's a mildly sanitized stack trace:

TypeError: extension.urlInfo is undefined resource://jid1-bmmwunrx3u5hqq-at-jetpack/wasavi/data/frontend/agent.js:1115:1 resource://jid1-bmmwunrx3u5hqq-at-jetpack/wasavi/data/frontend/agent.js:35:1

CaptSpify commented 10 years ago

I'm getting the same error on FF 32. I don't have vimfx.

console.error: wasavi: Message: TypeError: extension.urlInfo is undefined Stack: @resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/CaptSpify/.mozilla/firefox/kawcdxz1.default/extensions/jid1-VgrLFatWWJY3DA@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://jid1-bmmwunrx3u5hqq-at-jetpack/wasavi/data/frontend/agent.js:1115:1 @resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/CaptSpify/.mozilla/firefox/kawcdxz1.default/extensions/jid1-VgrLFatWWJY3DA@jetpack.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://jid1-bmmwunrx3u5hqq-at-jetpack/wasavi/data/frontend/agent.js:1127:1

mehertz commented 10 years ago

I'm assume I am also having this issue as I am unable to get wasavi to work even when using the latest build. I noted that the referenced change only has modifications to files under the chrome folder - surely that would not affect the firefox version, and thus would be unable to solve the issue?

akahuku commented 10 years ago

Although wasavi source is basically common by each browser, Chrome version is centric. And each source file in Opera/Firefox folder is symlink to Chrome version.

Therefore, even if the fix is for Firefox, source files that actually edited are in the Chrome folder.

akahuku commented 10 years ago

Please try out: version 0.6.292

fmoralesc commented 10 years ago

Works like a charm (on firefox nigthly 35)! Thanks a lot.

mehertz commented 10 years ago

Well the good news is it does launch now - but only when I select the "launch on focus" option. I'm unable to launch it with a key combination. Any idea as to why this is the case? I'm using Firefox 32.0.1 with vimperator (I have installed the JS file to the ~/vimperator/plugin).

Great work btw, this is an amazing plugin!

akahuku commented 10 years ago

Thank you, and what will happen if you disable Vimperator or disable Vimperator's plugins?

CaptSpify commented 10 years ago

I use vimperator, and had to restart firefox to get this working. Now it only works on some sites: examples: reddit comments work github comments dont work

I'm guessing it's because github is looking for ctrl+enter for it's submission, but I haven't had time to diagnose further

akahuku commented 10 years ago

Confirmed that wasavi for Firefox does not start on github. This occurs by Content-Security-Policy header in the http response header. Main part of wasavi is iframe element which has data: scheme source, however github's CSP refuses it. I'm now modifying somehow or other...

valir commented 9 years ago

I'm testing this http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_textarea with firefox 34.0.5 and the plugin won't trigger! The same works very well with Chromium.