akai-katto / dandere2x-python-rework

code to house the dandere2x python rework
10 stars 0 forks source link

Dandere2xPR 0.0.3.0 Feedback #2

Open DCGYT opened 1 year ago

DCGYT commented 1 year ago

LogoFanMade

Hi!

This new version of Dandere2x is a great improvement over previous versions, thanks to its better optimization, making less use of the CPU. Thanks to the new parameters it has been quite useful to have more information about how bugs are generated, so let's get to it.

Issues

The dots: This issue caused dots from previous frames to remain in the corners of blocks, in this case they remained white. This was solved by implementing a high "Quality Coefficent". If a low Quality Coefficent is used, this issue reappears.

Contrast: When using previous versions of Dandere2x you could see that the image looks with more contrast than normal, but from now on this is no longer the case. But the color tone still varies slightly from the original.

Lines: It is very difficult to know for sure how this is caused, but by using a high block and a low tile size I think this disappears.

Spots or Noise: This issue went down from version 0.0.2, but I still don't understand how this works. It would be great to have experimental settings in a future version to use for testing to see what changes can be made. Maybe a new yaml that is experimental options could be quite useful.

(Fade no longer exists, nor has Blur existed for some time.)

I have not been able to take specific screenshots now because I am testing in many ways and it would take too long, however I will be leaving the files on Google Drive.

https://drive.google.com/drive/folders/1ZxyjDErgJGih6EyGzMY_QBjTN2gwtMLV?usp=share_link

Thank you very much for this wonderful work, it shows an amazing change.

PS: I tried a file in DaVinci Resolve, but this one is not recognized :/

akai-katto commented 1 year ago

I'm currently focusing on getting dandere2x rework to work with davinci resolve (by relationship, other video player)