search

akai-katto / dandere2x

Dandere2x - Fast Waifu2x Video Upscaling.
https://www.reddit.com/r/Dandere2x/
GNU General Public License v3.0
1.45k stars 77 forks source link

Make videos look less shit. (#151) #153

Closed solonovamax closed 3 years ago

solonovamax commented 4 years ago

Changes the noise to use channel 0, aka the luminosity channel, making it looks less shit.

akai-katto commented 4 years ago

I'm currently working on a dandere2x overhaul, and adding this in to the next build / testing it out is on my radar.

A lot is fundementally changing behind the scenes so the MR will be on hold until then.

Thanks for the contribution! This is a starting point for me to investigate the roles of color formats in relation to dandere2x - I've sort of been ignoring it up until now

akai-katto commented 3 years ago

Working on this now - there's merge conflicts but reviewing it (after many many many months grr)

akai-katto commented 3 years ago

Unfortunately, this was submitted at a weird time in my life where I was moving out / I was assigned a new work project and put on crunch time, while dandere2x was going through an architecture overhaul. After months later, I've had the time to try this out, and I made the changes you proposed and put it into master.

I labeled you as a co-contributor, if you want I can give more contribution credit, but I did this to save myself from having to re-ask you to commit after many months later.

https://github.com/akai-katto/dandere2x/blob/master/src/config_files/output_options.yaml