akai-katto / dandere2x

Dandere2x - Fast Waifu2x Video Upscaling.
https://www.reddit.com/r/Dandere2x/
GNU General Public License v3.0
1.45k stars 77 forks source link

The 5 Errors of Dandere2x 3.7.2 (3.3.1 is better?) #281

Open DCGYT opened 1 year ago

DCGYT commented 1 year ago

Title I have decided to recapitulate all the bugs I have found all this time in just one post for ease of information.

Issues Table - Less is better

Issue Blur Color Dots Fade Lines Noise Spots Other Total Time
1.3.1 3 1 3 1 1 2 0 2 13 1:46
1.8 3 2 3 1 2 1 0 2 14 2:39
1.9 2 2 2 1 3 3 0 3 16 2:50
3.0.3 2 2 1 3 3 2 1 0 14 6:20
3.3.1 0 2 2 0 2 0 2 0 8 5:58
3.6 0 2 3 0 0 1 3 1 10 5:28
3.7.2 0 2 3 0 2 1 3 0 12 5:06
3.7.5 0 2 3 0 2 1 3 0 12 5:08
3.7.6 0 2 3 0 2 1 3 0 12 5:10
0.0.2.4 0 2 0 0 2 1 4 0 9 6:58
0.0.3 0 1 0 0 1 1 4 0 7
0.0.3C 0 1 0 0 0 1 4 0 6 11:13

*0.0.3 Config: [Cun][w2][s2][d3][q100][b60][t050][time673]

Blur: It is if the final video looks blurry compared to the best versions. Color: Color change from the original video Dots: In scenes with linear movement, the points remain at the corners of the blocks. Fade: In fade transitions, the blocks do not change. (3.6+ something similar happens because of the noise). Lines: In bright places flashing lines suddenly appear on the edges of the blocks. Noise: This is the image noise, very noticeable on TN screens. Spots: Dark edges in the grid and blocks that do not change color. Other: (1.3.1/1.8) Some blocks are slow to change. (1.9) Grid everywhere. (3.6) Time limit on slower PCs.

Check it out: https://drive.google.com/drive/folders/1euz0rhq-M-dQYPQME7QSTMTO9rfH2EDn?usp=share_link

3.7.2 Feedback

Version 3.7.2 fixed the time limit on less powerful computers from 3.6, however, it brought back the lines problem, which was the only reason for using 3.6 that was going to allow me to not scale the same video 2 times.

Another quite important bug is the spots in the video, the more the version advanced, the worse they got. In version 3.0.3 you could see dark edges in the grid, but already in 3.3 there started to be bugs in the color of the blocks, not changing its color generating slight differences between each block, and this became even more noticeable since 3.6.

I would also like to fix the issue of the dots in the corners, since for those scenes I have to use version 3.0.3, which has worse quality.

In minimal errors there is the issue that now again there is noise in the image, the plain colors now do not look completely smooth and in the GUI the letters are white on a white background.

For now I feel that the best version is 3.3.1, because it has the least bugs.

akai-katto commented 1 year ago

You don't realize how valuable this feedback is for me. I'll use this as a reference point on how to fix current dandere2x as well as drawing inspiration from the new dandere2x.

Seriously, thank you. I'm very impressed by the effort you put into this.

akai-katto commented 1 year ago

What settings were these used under?

DCGYT commented 1 year ago

@akai-katto I used maximum block and maximum image quality.

akai-katto commented 1 year ago

Hm, bigger block size typically is worse, I wish I had specified this before you went into it. Thanks though.

Curious to see if smaller block size (say 20?) has any improvement for your results?

DCGYT commented 1 year ago

@akai-katto I don't like to use low blocks, because you can easily see the grid. For example, lines, using a low block makes them more noticeable. But I will try it now.

DCGYT commented 1 year ago

@akai-katto I have tested 3.7.2 with block 20 and it is still the same. I uploaded the video of the test in Google Drive in the folder "Other Tests".

imageimageimage image

akai-katto commented 1 year ago

I got the same results.

I'll take a break from dandere2x rework to work on this.

akai-katto commented 1 year ago

https://drive.google.com/file/d/1Vq7QvMOdn7yk1PWLYX5QPniD3OEPlx8v/view?usp=sharing

Would you say this looks less noisy, or the same (this is dandere2x rework WIP)

DCGYT commented 1 year ago

@akai-katto A great improvement to the contrast which remains the same as 1.3.1! although the color still varies from the original tone, which I think must be difficult to correct.

The noise remains exactly the same. In the final part of the video is the key to see the noise. Or as I called it (spots). Maybe it would be better to use the 60 block, it's the same as the 20 but easier to identify.

image

akai-katto commented 1 year ago

how do you edit the photo to dramatize the spots? I can barely notice them on my VA monitor, so I'm trying to work around replicating it locally

akai-katto commented 1 year ago

here's blocksize 60 on new dandere2x, if you want to share your thoughts

https://drive.google.com/file/d/1dq7fQsWbNsmA16LyTSuv27Ts3MBjq_7V/view?usp=sharing

DCGYT commented 1 year ago

here's blocksize 60 on new dandere2x, if you want to share your thoughts

https://drive.google.com/file/d/1dq7fQsWbNsmA16LyTSuv27Ts3MBjq_7V/view?usp=sharing

Access denied xd

akai-katto commented 1 year ago

shared

DCGYT commented 1 year ago

@akai-katto I think the best program to see the noise is "avidemux", using a filter: Artistic > Dynamic Threshold. I don't know why I had not used this program before for testing. [Block 60] image

akai-katto commented 1 year ago

Does the input video demonstrate the same noise? I'm wondering if it's an input video error or dandere2x error. Hoping it's an input video error but we'll see.

DCGYT commented 1 year ago

@akai-katto This is what the original video looks like. It is noticeable that the noise is different, since in this one it is quite small, while the Dandere2x one is mostly grid-based. image

akai-katto commented 1 year ago

Thank you for your input. I'll research this tonight

akai-katto commented 1 year ago

Would you mind trying the new dandere2x prototype out, and leaving your thoughts on it? https://www.reddit.com/r/Dandere2x/comments/zctvfo/dandere2x_rework_proof_of_concept_ready_for/

DCGYT commented 1 year ago

@akai-katto I'll try it now, I only use Microsoft Defender so hopefully it won't be a problem xd.

DCGYT commented 1 year ago

@akai-katto At the moment it strikes me that it is using the integrated graphics xd, maybe I should start the program with the Nvidia manually later. image

akai-katto commented 1 year ago

let me fix this

akai-katto commented 1 year ago

https://github.com/akai-katto/dandere2x-python-rework/releases/tag/0.0.2

You should be able to download the latest versioning allowing selecting GPU in 0.0.2.1.

Simply goto your config_files, open up output_options.yaml, and change the following variables

waifu2x_ncnn_vulkan:
  model_name: "models-cunet"
  tile_size: 200  # note: if you get black images try lowering this tile argument to some lower value.
  pre_padding: 18
  client_ports:
    client0:
      gpuid: 0
      receive_port: 43560
      send_port: 43561
    client1:
      gpuid: 0
      receive_port: 43562
      send_port: 43563
    client2:
      gpuid: 0
      receive_port: 43564
      send_port: 43565
    client3:
      gpuid: 0
      receive_port: 43566
      send_port: 43567

->

waifu2x_ncnn_vulkan:
  model_name: "models-cunet"
  tile_size: 200  # note: if you get black images try lowering this tile argument to some lower value.
  pre_padding: 18
  client_ports:
    client0:
      gpuid: 1
      receive_port: 43560
      send_port: 43561
    client1:
      gpuid: 1
      receive_port: 43562
      send_port: 43563
    client2:
      gpuid: 1
      receive_port: 43564
      send_port: 43565
    client3:
      gpuid: 1
      receive_port: 43566
      send_port: 43567
DCGYT commented 1 year ago

@akai-katto Ok I'll try it, but I'll wait for this rendering to finish, it's 15 minutes left.

DCGYT commented 1 year ago

@akai-katto The result was the same as 3.7.2 with the same amount of errors, but slower. Now I will test the version with the GTX1050 GPU.

akai-katto commented 1 year ago

@akai-katto The result was the same as 3.7.2 with the same amount of errors, but slower. Now I will test the version with the GTX1050 GPU.

what quality setting did you use?

DCGYT commented 1 year ago

@akai-katto Everything to the maximum as always xd, because this way you can see the errors directly. Because whenever I use small blocks they are the same errors but in smaller boxes. (scale x2)

PD:now I will do it with block 20

DCGYT commented 1 year ago

@akai-katto denoise 3, scale 2x, block 20, image quality 100, 2 instances, time 6:21, same issues. The only major noticeable difference is the large reduction in CPU usage.

akai-katto commented 1 year ago

@akai-katto Everything to the maximum as always xd, because this way you can see the errors directly. Because whenever I use small blocks they are the same errors but in smaller boxes. (scale x2)

PD:now I will do it with block 20

https://github.com/akai-katto/dandere2x-python-rework/releases/download/0.0.2/uncapped_quality.exe

i uploaded "uncapped_quality.exe" which allows you to set quality up to 50k (lol).

I'm curious if you'd find the quality issues are fixed for you if the quality is set high enough.

akai-katto commented 1 year ago

@akai-katto denoise 3, scale 2x, block 20, image quality 100, 2 instances, time 6:21, same issues. The only major noticeable difference is the large reduction in CPU usage.

is it slower than 3.7.2 or 3.0.3?

DCGYT commented 1 year ago

@akai-katto I'm going to test with 4 instances, in addition I count 20 extra frames here than the tests.

DCGYT commented 1 year ago

@akai-katto denoise 3, scale x2, block 60, image quality 100, 4 instances, time 06:48, same issues. And unfortunately, another problem has been added. The video feels like it sticks in some parts. It's probably something about using 4 instances, since I had never used them, probably this bug is also in previous versions. By using only 2, the problem was reduced by half, surely this does not happen with only one instance. I will do this test now with only 1 instance and so I will equalize the conditions of all the tests.

akai-katto commented 1 year ago

darn, i thought i fixed the "sticking" parts. I'll upload another binary, can you let me know if it fixes it? I won't ask any more from you tonight, as it's getting late.

akai-katto commented 1 year ago

https://github.com/akai-katto/dandere2x-python-rework/releases/download/0.0.2/0.0.2.2.exe

DCGYT commented 1 year ago

@akai-katto I have no problem with the time, first I will test the version you had already sent with a single instance and see how it performs, then I will look at the new one.

akai-katto commented 1 year ago

On my end, the binary I sent you fixes the sticky issue.

DCGYT commented 1 year ago

@akai-katto In the previous version with a single instance it is solved checked. denoise 3, scale x2, block 60, image quality 100, 1 instance, time 08:20, same issues. Although this new Dandere2x I do not know if it has corrected the dots because I have not seen any, but I would have to do more tests. Now I'm going to test the new version with 2 instances

akai-katto commented 1 year ago

Thanks for testing btw, I'm relying on the community to catch bugs like this.

DCGYT commented 1 year ago

@akai-katto denoise 3, scale x2, block 60, image quality 100, 2 instances, time 06:51, same issues 3.7.2 Sticky video corrected. It's a big improvement with version 3.7.2 in optimization issues, it has lowered my processor temperature by 10°C.

The time considered in the other tests goes from frame 10 to 350, this one too, but considering that, in the previous tests they didn't take the time of the frame extraction or whatever happened before that I don't understand much xd.

The most serious error that I see now are the "spots" or "noise" that is very noticeable.

@akai-katto compared to 3.7.2 which had a lot of dots, I think it was corrected in this version. So it would be the version with less bugs, although as the "spots" or "noise" are so exaggerated, I will give it a 4.

I left the test there if you want to see the differences. image

The color remains the same as in 3.7.2. I would like it to be corrected like the 3.7.2 correction of 2 days ago.

https://drive.google.com/file/d/1Vq7QvMOdn7yk1PWLYX5QPniD3OEPlx8v/view?usp=sharing

Would you say this looks less noisy, or the same (this is dandere2x rework WIP)

DCGYT commented 1 year ago

image The progress of the new Dandere2x is incredible. "Quality Coefficent": If this is low it generates the problem of the dots. So, by having it at 100, this is solved. Lines still appear depending on the configuration The processor heats less, the error of the dots, lines, color was corrected, the only thing that remains is the noise. With this configuration I have managed to reduce everything as much as possible. Test_[Cun][w2][s2][d3][q100][b60][t050]

It is already too late, tomorrow I will take a closer look at the tests and see which one is better in each area. https://drive.google.com/drive/folders/1ZxyjDErgJGih6EyGzMY_QBjTN2gwtMLV?usp=share_link