search

akai-org / akai-webpage

https://akai.org.pl/
0 stars 0 forks source link

style: add LinkedIn icon wrapped in anchor #44

Closed kalkson closed 2 years ago

kalkson commented 2 years ago

image image

Related with #42

roertbb commented 2 years ago

Isn't the LinkedIn icon in the footer squeezed in a little due to border? See

Screenshot 2021-12-16 at 19 27 46

Restructured them a little in https://github.com/akai-org/akai-webpage/pull/44/commits/a4e1fbb81b3241caafc1ebf19836a88e1b46b168 - wdyt?

kalkson commented 2 years ago

Do not use padding to svg elements. It always go bad 😅 Nice ✅

roertbb commented 2 years ago

So you'd rather go with https://github.com/akai-org/akai-webpage/pull/44/commits/195e00c9cfc8173273763216c5be3cb1a9e5eeaa? If you see some improvement - fell free to adjust it and teach me please on the benefits of doing it one way, not the other 😄

kalkson commented 2 years ago

Definitely