akaita / easylauncher-gradle-plugin

Add a different ribbon to each of your Android app variants using this gradle plugin. Of course, configure it as you will
Apache License 2.0
959 stars 52 forks source link

Upcoming incompatibility with Gradle 7 #45

Open WarrenFaith opened 4 years ago

WarrenFaith commented 4 years ago

I was just running a build with full warning output and got this warnings:

> Task :app:easylauncherGoogleBetaRelease
Property 'androidManifestFiles' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0.
Property 'filters' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0.
Property 'foregroundIconNames' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0.
Property 'iconNames' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0.
Property 'launcherIconNames' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0.
Property 'outputDir' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0.
Property 'variant' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0.
emartynov commented 4 years ago

This is probably will be solved by solving #46

WarrenFaith commented 4 years ago

So you felt the urge to create a new issue instead of just providing additional information to an existing one? Great!

emartynov commented 4 years ago

It is nice to judge people based on your assumptions. I have assumptions that support of cache will fix this problem. But I'm not sure. True, I should check other tickets before I opened another one. But closing ticket as duplicate is also not expensive operation.

WarrenFaith commented 4 years ago

I judge people based on their actions. You commented here a minute after you created the issue and this issue was top of list.

But closing ticket as duplicate is also not expensive operation.

Feel free to do the "not expensive operation" yourself. Why should the project maintainer should do that if you can do that yourself or even have prevented it in the first place by a bit more research on your side?

emartynov commented 4 years ago

Thank you, and I will leave this decision to the project maintainer :)

EmmanuelMess commented 3 years ago

Gradle 7.0 is here, any news?

emartynov commented 3 years ago

https://github.com/usefulness/easylauncher-gradle-plugin