akamai / AkamaiOPEN-edgegrid-python

This library implements an Authentication handler for the Akamai OPEN EdgeGrid Authentication scheme
Apache License 2.0
88 stars 52 forks source link

There is no explicit indication anywhere obvious whether this package supports both python2 and python3 #37

Closed vitaly-krugl closed 3 years ago

vitaly-krugl commented 5 years ago

Please add an explicit indication whether this package supports both python2 and python3. Ideally, this should be reflected in the classifiers parameter when your setup.py is calling setuptools.setup() (see https://packaging.python.org/guides/distributing-packages-using-setuptools/#classifiers and https://pypi.org/classifiers/). For example:

setup(
    ...
    classifiers=[
        'Programming Language :: Python :: 2',
        'Programming Language :: Python :: 2.7',
        'Programming Language :: Python :: 3',
        'Programming Language :: Python :: 3.7'
    ]
)

Also, it wouldn't hurt to add specific, enforceable, supported python versions into python_requires, for example:

    # Require Python 2.7.10+ or Python 3 starting with 3.7 (per PEP-440)
    python_requires='>=2.7.10, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, '
                    '!=3.5.*, !=3.6.*, <4',
robertolopezlopez commented 3 years ago

Thank you @vitaly-krugl ,

We have addressed this issue in our internal repository and soon it will be released.

Regards

robertolopezlopez commented 3 years ago

Hi @vitaly-krugl ,

This issue has been addressed in our latest release. Thank you for bringing up this topic.

Regards,

Roberto