akamai / NetStorageKit-Node

Akamai NetStorage API for Node
Apache License 2.0
20 stars 15 forks source link

Dir and List API Options #3

Closed bobbyjball3 closed 7 years ago

bobbyjball3 commented 7 years ago

Enhancements

Bug Fixes

N/A

Breaking changes

bobbyjball3 commented 7 years ago

@AstinCHOI You might consider setting the environment variables in your Travis repo configuration rather than as secret values in the Travis YAML. The reason being that secret env variables are not accessible on pull requests (which is why builds are always failing on pull reqs)

Reference Here

"...Encrypted variables are not available to untrusted builds such as pull requests coming from another repository..."

AstinCHOI commented 7 years ago

Dear @bobbyjball3,

I tested and merged it. As you suggested, I remove the secure vals in Travis YAML and add them to its setting. You may test for next pull request !

Thank you !