Closed bdhanalakshmi-chwy closed 2 years ago
Thanks a lot for the PR, indeed this will be a good addition to the docker image.
Please also
- add the appropriate lines to the /variants file so that the akamai/gtm variant is built, and so it is included in the akamai/shell image (currently nothing will happen).
- add a simple sanity test to the /tests.bats file
- add the variant to the matrix in the /README.md file
- address the inline comment regarding the ENTRYPOINT
yes, ENTRYPOINTS added for testing, i have removed this line
Thanks @bdhanalakshmi-chwy, this looks good in general, I will update this once tested.
Thanks @bdhanalakshmi-chwy, this looks good in general, I will update this once tested.
Thanks @ynohat
rebased and merged
Akamai docker shell missing the GTM CLI package, we need to include the GTM packages in the akamai shell