akamai / akamai-docker

Dockerfile for official Akamai's DevOps environment containing CLI packages and useful tools
Apache License 2.0
39 stars 15 forks source link

Akamai gtm cli docker files #66

Closed bdhanalakshmi-chwy closed 2 years ago

bdhanalakshmi-chwy commented 2 years ago

Akamai docker shell missing the GTM CLI package, we need to include the GTM packages in the akamai shell

bdhanalakshmi-chwy commented 2 years ago

Thanks a lot for the PR, indeed this will be a good addition to the docker image.

Please also

  • add the appropriate lines to the /variants file so that the akamai/gtm variant is built, and so it is included in the akamai/shell image (currently nothing will happen).
  • add a simple sanity test to the /tests.bats file
  • add the variant to the matrix in the /README.md file
  • address the inline comment regarding the ENTRYPOINT

yes, ENTRYPOINTS added for testing, i have removed this line

ynohat commented 2 years ago

Thanks @bdhanalakshmi-chwy, this looks good in general, I will update this once tested.

bdhanalakshmi-chwy commented 2 years ago

Thanks @bdhanalakshmi-chwy, this looks good in general, I will update this once tested.

Thanks @ynohat

ynohat commented 2 years ago

rebased and merged