AutoXHR: Adding xhr.ru (response URL) beacon parameter for XHR and Fetch

akamai / boomerang

End user oriented web performance testing and beaconing

http://akamai.github.io/boomerang/

Other

1.86k stars 293 forks source link

AutoXHR: Adding xhr.ru (response URL) beacon parameter for XHR and Fetch #300

Closed sukratkashyap closed 3 years ago

sukratkashyap commented 4 years ago

Adding new ru beacon parameter which contains the Response Url when XHR request is made.

XMLHttpRequest: https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/responseURL
fetch: https://developer.mozilla.org/en-US/docs/Web/API/Response/url

sukratkashyap commented 4 years ago

@nicjansma @bluesmoon Thank you guys for the comments. I have made the changes as suggested.

nicjansma commented 4 years ago

Not related to your changes, but looks like E2E tests are failing due to:

E/launcher - SessionNotCreatedError: session not created: This version of ChromeDriver only supports Chrome version 84

In our internal repo, we lock webdriver and chromedriver at specific versions during CI tests. I'll need to see how easy that would be to do in the Github actions files.

SaschaBrechmannVHV commented 3 years ago

Hi, could this PR merged? The new xhr.ru variable looks good. Regards, Sascha

nicjansma commented 3 years ago

Yes! Merged via dd558a515be0d730ca8479b2d5ef8e0dcedcd253