Closed liufei closed 1 year ago
Hi @bluesmoon , @ceckoslab , @andreas-marschke , @ashenoy2014 , @nicjansma could this PR be Merged ?
Regards, Sascha
@liufei @SaschaBrechmannVHV Thank you for the changes. We will take a look soon. In the mean time, have you thought about what sort of test can be added to cover this? If you can, that would be super helpful!
Thanks for opening this PR @liufei. I've added a test (in our internal repo), and will backport it here shortly. Since I can't push to your remote, I'll commit to our main branch and close this PR out once it's available.
@ashenoy2014 @nicjansma You're welcome. Due to the incompatibility of the MacBook Pro M1 chip with e2e testing, there is currently no solution available, and therefore the test has not been submitted.
@SaschaBrechmannVHV Although the PR won't be merged, I appreciate your attention to this issue and hope that all Lottie users won't be affected by this problem and can still use Boomerang normally.
Merged in with https://github.com/akamai/boomerang/commit/9e7063e9c827ec48d6c01b213d5b3c40009b3b88
Thanks @liufei !