akamai / boomerang

End user oriented web performance testing and beaconing
http://akamai.github.io/boomerang/
Other
1.86k stars 292 forks source link

Global collision issue #342

Closed RyanGao-EM closed 1 year ago

RyanGao-EM commented 1 year ago

Here “i" doesn’t have var(var i = 0;) and it becomes global variable, so it’s causing issues with our script.

 isSinglePageApp: function(e) {
                var t = !1
                  , n = this.supported_frameworks();
                for (i = 0; i < n.length; i++) { // <========== var i
                    var r = n[i];
                    if (e[r] && e[r].enabled) {
                        t = !0;
                        break
                    }
                }
                return t
            } 
bluesmoon commented 1 year ago

Good catch.

nicjansma commented 1 year ago

We'll backport this fix to our mPulse-specific boomerang.js as well